Editing Forum:Centralize spirit battles

From SmashWiki, the Super Smash Bros. wiki
Jump to navigationJump to search
Warning You aren't logged in. While it's not a requirement to create an account, doing so makes it a lot easier to keep track of your edits and a lot harder to confuse you with someone else. If you edit without being logged in, your IP address will be recorded in the page's edit history.

The edit can be undone. Please check the comparison below to verify that this is what you want to do, and then publish the changes below to finish undoing the edit.

Latest revision Your text
Line 1: Line 1:
{{forumheader|Proposals}}<!-- Please put your content below this line. Be sure to sign your edits with four tildes: ~~~~ -->
{{forumheader|Proposals}}<!-- Please put your content below this line. Be sure to sign your edits with four tildes: ~~~~ -->
{{Proposal|failed|The risk of a mistake on a template of this size and potential usage is too great. See latest comment for more clarification. --[[User:CanvasK|CanvasK]] ([[User talk:CanvasK|talk]]) 08:34, June 2, 2020 (EDT)}}
{{Proposal}}
Spirit Battle tables in their current state are a little... messy. If a user feels that it is necessary to make an edit to a battle entry, they will need to hunt down every usage of that battle entry. Here's a hypothetical: I want to make an edit to the 'Hungry Luma' spirit battle (wrong type, song, whatever). Easy, I go to the list of [[List_of_spirits_(Super_Mario_series)|Super Mario spirits]] and change it. Done? Nope. Now I go to [[Rosalina & Luma (SSBU)|Rosalina]]'s page, edit, go to [[Kirby (SSBU)|Kirby]]'s page, edit, and now I'm hopefully done. A recent headache came from [[Cuphead]]'s spirit battle where it changes if you have DLC, now the edit needs to be made on [[Ready%3F_Wallop!]], [[Peach_(SSBU)]], [[Mega_Man_(SSBU)]], [[Mii_Gunner_(SSBU)]], and [[List_of_spirits_(Others)]]. This will only grow as we have about two more years of content coming.
Spirit Battle tables in their current state are a little... messy. If a user feels that it is necessary to make an edit to a battle entry, they will need to hunt down every usage of that battle entry. Here's a hypothetical: I want to make an edit to the 'Hungry Luma' spirit battle (wrong type, song, whatever). Easy, I go to the list of [[List_of_spirits_(Super_Mario_series)|Super Mario spirits]] and change it. Done? Nope. Now I go to [[Rosalina & Luma (SSBU)|Rosalina]]'s page, edit, go to [[Kirby (SSBU)|Kirby]]'s page, edit, and now I'm hopefully done. A recent headache came from [[Cuphead]]'s spirit battle where it changes if you have DLC, now the edit needs to be made on [[Ready%3F_Wallop!]], [[Peach_(SSBU)]], [[Mega_Man_(SSBU)]], [[Mii_Gunner_(SSBU)]], and [[List_of_spirits_(Others)]]. This will only grow as we have about two more years of content coming.


Line 21: Line 21:
==Comments==
==Comments==
I've done some research and have made a mock-up of what I was thinking (below). It is based around the rows that are currently used for spirit battles with the only changes being the image size and how numbers are displayed, but that can easily be changed. There are 2 parts: SpiritBattleRow and SpiritBattleTable. SpiritBattleRow is used to construct the rows with quite a few parameters. SpiritBattleTable has 2 parameters: number, which controls the switch function (currently only a few spirits are programmed); and seriesoff, which removes the 'series' cell if it is filled, which will make it look like the rows on the "List of Spirits (___ Series)".
I've done some research and have made a mock-up of what I was thinking (below). It is based around the rows that are currently used for spirit battles with the only changes being the image size and how numbers are displayed, but that can easily be changed. There are 2 parts: SpiritBattleRow and SpiritBattleTable. SpiritBattleRow is used to construct the rows with quite a few parameters. SpiritBattleTable has 2 parameters: number, which controls the switch function (currently only a few spirits are programmed); and seriesoff, which removes the 'series' cell if it is filled, which will make it look like the rows on the "List of Spirits (___ Series)".
<Template removed>
{|class="wikitable"
|-
{{User:CanvasK/SpiritBattleTable|number=104}}
|}
Currently it isn't able to handle spirits like Cuphead where they are different if you have DLC. But I do have a WIP design that incorporates it into SpiritBattleRow, but I'm thinking a separate SpiritBattleRowDLC would be cleaner.
Currently it isn't able to handle spirits like Cuphead where they are different if you have DLC. But I do have a WIP design that incorporates it into SpiritBattleRow, but I'm thinking a separate SpiritBattleRowDLC would be cleaner.
--[[User:CanvasK|CanvasK]] ([[User_talk:CanvasK|talk]]) 17:03, March 20, 2020 (EDT)
--[[User:CanvasK|CanvasK]] ([[User_talk:CanvasK|talk]]) 17:03, March 20, 2020 (EDT)
*Not long ago I corrected the information between the Fighter and Series Lists, which lead me to compile all of the information from the pages. This means I already have all of the data needed to make the full template/list. Thinking on it, I do acknowledge that me correcting the information partially defeats the purpose of this proposal, however there is still the point of adding hidden data (such as stats or unknown conditions) if it becomes available.--[[User:CanvasK|CanvasK]] ([[User_talk:CanvasK|talk]]) 09:47, April 14, 2020 (EDT)
*Not long ago I corrected the information between the Fighter and Series Lists, which lead me to compile all of the information from the pages. This means I already have all of the data needed to make the full template/list. Thinking on it, I do acknowledge that me correcting the information partially defeats the purpose of this proposal, however there is still the point of adding hidden data (such as stats or unknown conditions) if it becomes available.--[[User:CanvasK|CanvasK]] ([[User_talk:CanvasK|talk]]) 09:47, April 14, 2020 (EDT)
Despite the support this proposal has gained I have decided to close it. Recently there was an issue with the SSB4 to SSBU changelist that caused server issues; the cause being a single missing curly bracket. I fear that a similar thing could happen with this proposed template.
By my estimations the template would be around 600K bytes, which is less than the changelist's 1000K bytes. However, with my current test implementations the template would be called dozens of times on each page it is used on, and there are about twice as many pages that include Spirit battles than there are fighter pages. On "List of Spirits (Others)" there are over 200 battles, if each one had to load the 600K bytes due to the template breaking then a potential 120000K bytes would be loaded on that page alone.
As such I'm closing this proposal. Other alternatives would be a page or a spreadsheet where the battles can be copy-pasted. If I ever decide to do one of those I will probably link it on the [[Spirit]] talk page. The best thing to do right now would be to keep on top of edits made to battles (which thankfully there are very few now) and make sure they are reflected to other pages with those battles. --[[User:CanvasK|CanvasK]] ([[User talk:CanvasK|talk]]) 08:34, June 2, 2020 (EDT)

Please note that all contributions to SmashWiki are considered to be released under the Attribution-ShareAlike 3.0 Unported license (see SmashWiki:Copyrights for details). Your changes will be visible immediately. Please enter a summary of your changes above.

Do not submit copyrighted work without permission!

Cancel Editing help (opens in new window)